chore: enhance error message clarity and verbosity [ROW-252] #160
Conversation
🦋 Changeset detectedLatest commit: fe66808 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bundle Size Report
|
|||||||||||||||||||||||||||||||||||
| 🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
|---|
| Parsed (kb) | |||||
|---|---|---|---|---|---|
| 🚦 | File Name | Base | PR | Diff | % |
| 📈 | cjs/index.js |
154.02 |
158 |
|
2.58 |
| 📈 | esm/index.min.js |
56.25 |
60.11 |
|
6.86 |
| 📈 | umd/index.js |
175.15 |
179.13 |
|
2.27 |
This comment has been minimized.
This comment has been minimized.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 96.70% 96.59% -0.12%
==========================================
Files 51 51
Lines 699 704 +5
Branches 171 173 +2
==========================================
+ Hits 676 680 +4
- Misses 23 24 +1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
| if (!locale) throw new Error('Pass valid locale !'); | ||
| if (!locale) | ||
| throw new Error( | ||
| `The provided locale value is invalid. The received value was: ${locale}. Please ensure you pass a correct locale string for proper formatting.`, |
There was a problem hiding this comment.
Let's attach a link for valid locale list too ?
There was a problem hiding this comment.
We don't have any such list maintained in our codebase.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
This pull request refactors the error messages throughout the codebase to be more verbose and descriptive. The changes aim to provide clearer and more detailed information about the errors, making it easier for developers to understand what went wrong and how to fix it.
Changes include:
Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>Types can be as follows:
feat: (new feature for the user, not a new feature for build script)fix: (bug fix for the user, not a fix to a build script)docs: (changes to the documentation)style: (formatting, missing semi colons, etc; no production code change)refactor: (refactoring production code, eg. renaming a variable)test: (adding missing tests, refactoring tests; no production code change)chore: (updating grunt tasks etc; no production code change)